initial
This commit is contained in:
180
tests/Feature/TravelRequest/ApprovalTest.php
Normal file
180
tests/Feature/TravelRequest/ApprovalTest.php
Normal file
@@ -0,0 +1,180 @@
|
||||
<?php
|
||||
|
||||
namespace Tests\Feature\TravelRequest;
|
||||
|
||||
use App\Enums\ApprovalStatus;
|
||||
use App\Enums\TravelStatus;
|
||||
use App\Jobs\SendApprovalDecisionEmail;
|
||||
use App\Jobs\SendApprovalRequestEmail;
|
||||
use App\Models\ApprovalStep;
|
||||
use App\Models\ApprovalWorkflow;
|
||||
use App\Models\TravelRequest;
|
||||
use App\Models\TravelRequestApproval;
|
||||
use App\Models\User;
|
||||
use App\Services\ApprovalService;
|
||||
use Database\Seeders\RoleSeeder;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Tests\TestCase;
|
||||
|
||||
class ApprovalTest extends TestCase
|
||||
{
|
||||
use RefreshDatabase;
|
||||
|
||||
protected User $staff;
|
||||
protected User $approver;
|
||||
protected ApprovalWorkflow $workflow;
|
||||
protected ApprovalStep $step1;
|
||||
protected ApprovalStep $step2;
|
||||
|
||||
protected function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
$this->seed(RoleSeeder::class);
|
||||
|
||||
$this->staff = User::factory()->create();
|
||||
$this->staff->assignRole('staff');
|
||||
|
||||
$this->approver = User::factory()->create();
|
||||
$this->approver->assignRole('travel_approver');
|
||||
|
||||
$this->workflow = ApprovalWorkflow::factory()->create(['is_active' => true]);
|
||||
$this->step1 = ApprovalStep::factory()->create([
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'order' => 1,
|
||||
'role' => 'travel_approver',
|
||||
]);
|
||||
$this->step2 = ApprovalStep::factory()->create([
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'order' => 2,
|
||||
'role' => 'administrator',
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_submitting_request_creates_approval_records_and_dispatches_email(): void
|
||||
{
|
||||
Queue::fake();
|
||||
|
||||
$request = TravelRequest::factory()->create([
|
||||
'user_id' => $this->staff->id,
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'status' => TravelStatus::Draft,
|
||||
]);
|
||||
|
||||
app(ApprovalService::class)->submit($request);
|
||||
|
||||
$request->refresh();
|
||||
$this->assertEquals(TravelStatus::Pending, $request->status);
|
||||
$this->assertNotNull($request->submitted_at);
|
||||
$this->assertDatabaseHas('travel_request_approvals', [
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step1->id,
|
||||
'status' => ApprovalStatus::Pending->value,
|
||||
]);
|
||||
|
||||
Queue::assertPushed(SendApprovalRequestEmail::class);
|
||||
}
|
||||
|
||||
public function test_approving_first_step_advances_to_second_step(): void
|
||||
{
|
||||
Queue::fake();
|
||||
|
||||
$request = TravelRequest::factory()->create([
|
||||
'user_id' => $this->staff->id,
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'status' => TravelStatus::Pending,
|
||||
'submitted_at' => now(),
|
||||
]);
|
||||
|
||||
$approval1 = TravelRequestApproval::create([
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step1->id,
|
||||
'status' => ApprovalStatus::Pending->value,
|
||||
]);
|
||||
TravelRequestApproval::create([
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step2->id,
|
||||
'status' => null,
|
||||
]);
|
||||
|
||||
app(ApprovalService::class)->approve($approval1, $this->approver, 'Looks good');
|
||||
|
||||
$approval1->refresh();
|
||||
$this->assertEquals(ApprovalStatus::Approved, $approval1->status);
|
||||
$this->assertEquals($this->approver->id, $approval1->approver_id);
|
||||
|
||||
$this->assertDatabaseHas('travel_request_approvals', [
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step2->id,
|
||||
'status' => ApprovalStatus::Pending->value,
|
||||
]);
|
||||
|
||||
Queue::assertPushed(SendApprovalRequestEmail::class);
|
||||
}
|
||||
|
||||
public function test_approving_final_step_marks_request_as_approved(): void
|
||||
{
|
||||
Queue::fake();
|
||||
|
||||
$request = TravelRequest::factory()->create([
|
||||
'user_id' => $this->staff->id,
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'status' => TravelStatus::Pending,
|
||||
]);
|
||||
|
||||
TravelRequestApproval::create([
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step1->id,
|
||||
'status' => ApprovalStatus::Approved->value,
|
||||
'approver_id' => $this->approver->id,
|
||||
'acted_at' => now(),
|
||||
]);
|
||||
$finalApproval = TravelRequestApproval::create([
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step2->id,
|
||||
'status' => ApprovalStatus::Pending->value,
|
||||
]);
|
||||
|
||||
$admin = User::factory()->create();
|
||||
$admin->assignRole('administrator');
|
||||
app(ApprovalService::class)->approve($finalApproval, $admin, null);
|
||||
|
||||
$request->refresh();
|
||||
$this->assertEquals(TravelStatus::Approved, $request->status);
|
||||
|
||||
Queue::assertPushed(SendApprovalDecisionEmail::class);
|
||||
}
|
||||
|
||||
public function test_rejection_marks_request_as_rejected_and_dispatches_email(): void
|
||||
{
|
||||
Queue::fake();
|
||||
|
||||
$request = TravelRequest::factory()->create([
|
||||
'user_id' => $this->staff->id,
|
||||
'workflow_id' => $this->workflow->id,
|
||||
'status' => TravelStatus::Pending,
|
||||
]);
|
||||
|
||||
$approval = TravelRequestApproval::create([
|
||||
'travel_request_id' => $request->id,
|
||||
'approval_step_id' => $this->step1->id,
|
||||
'status' => ApprovalStatus::Pending->value,
|
||||
]);
|
||||
|
||||
app(ApprovalService::class)->reject($approval, $this->approver, 'Budget not available');
|
||||
|
||||
$request->refresh();
|
||||
$this->assertEquals(TravelStatus::Rejected, $request->status);
|
||||
$this->assertEquals('Budget not available', $approval->fresh()->comments);
|
||||
|
||||
Queue::assertPushed(SendApprovalDecisionEmail::class);
|
||||
}
|
||||
|
||||
public function test_approve_page_requires_approver_role(): void
|
||||
{
|
||||
$request = TravelRequest::factory()->create(['user_id' => $this->staff->id]);
|
||||
$this->actingAs($this->staff)
|
||||
->get("/travel-requests/{$request->id}/approve")
|
||||
->assertForbidden();
|
||||
}
|
||||
}
|
||||
110
tests/Feature/TravelRequest/CreateTest.php
Normal file
110
tests/Feature/TravelRequest/CreateTest.php
Normal file
@@ -0,0 +1,110 @@
|
||||
<?php
|
||||
|
||||
namespace Tests\Feature\TravelRequest;
|
||||
|
||||
use App\Enums\JourneyMethod;
|
||||
use App\Enums\TravelStatus;
|
||||
use App\Models\ApprovalStep;
|
||||
use App\Models\ApprovalWorkflow;
|
||||
use App\Models\TravelRequest;
|
||||
use App\Models\User;
|
||||
use Database\Seeders\RoleSeeder;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Tests\TestCase;
|
||||
|
||||
class CreateTest extends TestCase
|
||||
{
|
||||
use RefreshDatabase;
|
||||
|
||||
protected function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
$this->seed(RoleSeeder::class);
|
||||
}
|
||||
|
||||
public function test_create_page_requires_authentication(): void
|
||||
{
|
||||
$this->get('/travel-requests/create')->assertRedirect('/login');
|
||||
}
|
||||
|
||||
public function test_authenticated_user_can_access_create_page(): void
|
||||
{
|
||||
$user = User::factory()->create();
|
||||
$user->assignRole('staff');
|
||||
|
||||
$this->actingAs($user)->get('/travel-requests/create')->assertStatus(200);
|
||||
}
|
||||
|
||||
public function test_travel_request_is_created_as_draft(): void
|
||||
{
|
||||
$user = User::factory()->create();
|
||||
$user->assignRole('staff');
|
||||
|
||||
$workflow = ApprovalWorkflow::factory()->create(['is_active' => true]);
|
||||
ApprovalStep::factory()->create(['workflow_id' => $workflow->id, 'order' => 1, 'role' => 'travel_approver']);
|
||||
|
||||
$this->actingAs($user);
|
||||
|
||||
$requestData = [
|
||||
'emergencyFullName' => 'Jane Doe',
|
||||
'emergencyPhone' => '0400000000',
|
||||
'emergencyRelationship' => 'Spouse',
|
||||
'reasonSummary' => 'Attending the annual conference in Sydney.',
|
||||
'travelCategory' => 'event',
|
||||
'eventType' => 'Conference',
|
||||
'journeys' => [[
|
||||
'origin' => 'Perth',
|
||||
'destination' => 'Sydney',
|
||||
'date' => now()->addDays(30)->format('Y-m-d'),
|
||||
'time' => '08:00',
|
||||
'method' => JourneyMethod::Air->value,
|
||||
]],
|
||||
'needsAccommodation' => true,
|
||||
'needsCarHire' => false,
|
||||
'vehiclePolicyAcknowledged' => false,
|
||||
'businessDays' => 3,
|
||||
'privateDays' => 0,
|
||||
'costCodes' => [[
|
||||
'business_unit' => 'MED',
|
||||
'project_grant' => 'PG-12345',
|
||||
'account_code' => 'AC001',
|
||||
'class_code' => '',
|
||||
]],
|
||||
];
|
||||
|
||||
\Livewire\Livewire::test('travel-request.create')
|
||||
->set('emergencyFullName', $requestData['emergencyFullName'])
|
||||
->set('emergencyPhone', $requestData['emergencyPhone'])
|
||||
->set('emergencyRelationship', $requestData['emergencyRelationship'])
|
||||
->set('reasonSummary', $requestData['reasonSummary'])
|
||||
->set('journeys', $requestData['journeys'])
|
||||
->call('saveDraft');
|
||||
|
||||
$this->assertDatabaseHas('travel_requests', [
|
||||
'user_id' => $user->id,
|
||||
'status' => TravelStatus::Draft->value,
|
||||
]);
|
||||
}
|
||||
|
||||
public function test_journey_validation_requires_origin_and_destination(): void
|
||||
{
|
||||
$user = User::factory()->create();
|
||||
$user->assignRole('staff');
|
||||
$this->actingAs($user);
|
||||
|
||||
\Livewire\Livewire::test('travel-request.create')
|
||||
->set('reasonSummary', 'Test reason for travel purpose')
|
||||
->set('emergencyFullName', 'Jane Doe')
|
||||
->set('emergencyPhone', '0400000000')
|
||||
->set('emergencyRelationship', 'Spouse')
|
||||
->set('journeys', [[
|
||||
'origin' => '',
|
||||
'destination' => '',
|
||||
'date' => now()->addDays(10)->format('Y-m-d'),
|
||||
'time' => '',
|
||||
'method' => JourneyMethod::Air->value,
|
||||
]])
|
||||
->call('saveDraft')
|
||||
->assertHasErrors(['journeys.0.origin', 'journeys.0.destination']);
|
||||
}
|
||||
}
|
||||
58
tests/Feature/TravelRequest/DashboardTest.php
Normal file
58
tests/Feature/TravelRequest/DashboardTest.php
Normal file
@@ -0,0 +1,58 @@
|
||||
<?php
|
||||
|
||||
namespace Tests\Feature\TravelRequest;
|
||||
|
||||
use App\Enums\TravelStatus;
|
||||
use App\Models\TravelRequest;
|
||||
use App\Models\User;
|
||||
use Database\Seeders\RoleSeeder;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Tests\TestCase;
|
||||
|
||||
class DashboardTest extends TestCase
|
||||
{
|
||||
use RefreshDatabase;
|
||||
|
||||
protected function setUp(): void
|
||||
{
|
||||
parent::setUp();
|
||||
$this->seed(RoleSeeder::class);
|
||||
}
|
||||
|
||||
public function test_dashboard_requires_authentication(): void
|
||||
{
|
||||
$this->get('/dashboard')->assertRedirect('/login');
|
||||
}
|
||||
|
||||
public function test_staff_sees_only_own_requests(): void
|
||||
{
|
||||
$staff = User::factory()->create();
|
||||
$staff->assignRole('staff');
|
||||
|
||||
$otherUser = User::factory()->create();
|
||||
$otherUser->assignRole('staff');
|
||||
|
||||
TravelRequest::factory()->create(['user_id' => $staff->id]);
|
||||
TravelRequest::factory()->create(['user_id' => $otherUser->id]);
|
||||
|
||||
$response = $this->actingAs($staff)->get('/dashboard');
|
||||
$response->assertStatus(200);
|
||||
}
|
||||
|
||||
public function test_approver_can_see_all_requests(): void
|
||||
{
|
||||
$approver = User::factory()->create();
|
||||
$approver->assignRole('travel_approver');
|
||||
|
||||
$staff1 = User::factory()->create();
|
||||
$staff1->assignRole('staff');
|
||||
$staff2 = User::factory()->create();
|
||||
$staff2->assignRole('staff');
|
||||
|
||||
TravelRequest::factory()->create(['user_id' => $staff1->id]);
|
||||
TravelRequest::factory()->create(['user_id' => $staff2->id]);
|
||||
|
||||
$response = $this->actingAs($approver)->get('/dashboard');
|
||||
$response->assertStatus(200);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user