Merge pull request 'Fix form submission staying in draft status' (#13) from fix/submit-draft-status into master

Reviewed-on: #13
2026-03-06 12:29:00 +08:00
parent 35723fb226 e01caf678b
commit 7b26fc57f4
3 changed files with 137 additions and 2 deletions
--- a/tests/Feature/TravelRequestSubmissionTest.php
+++ b/tests/Feature/TravelRequestSubmissionTest.php
@@ -0,0 +1,124 @@
+<?php
+
+namespace Tests\Feature;
+
+use App\Enums\ApprovalStatus;
+use App\Enums\JourneyMethod;
+use App\Enums\TravelStatus;
+use App\Models\ApprovalStep;
+use App\Models\ApprovalWorkflow;
+use App\Models\TravelRequest;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Livewire\Livewire;
+use Spatie\Permission\Models\Role;
+use Tests\TestCase;
+
+class TravelRequestSubmissionTest extends TestCase
+{
+    use RefreshDatabase;
+
+    private User $staff;
+
+    /** @var array<string, mixed> */
+    private array $validFormData;
+
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        Role::firstOrCreate(['name' => 'staff']);
+        Role::firstOrCreate(['name' => 'travel_approver']);
+        Role::firstOrCreate(['name' => 'administrator']);
+
+        $this->staff = User::factory()->create();
+        $this->staff->assignRole('staff');
+
+        $this->validFormData = [
+            'emergencyFullName' => 'Jane Doe',
+            'emergencyPhone' => '0400000000',
+            'emergencyRelationship' => 'Spouse',
+            'reasonSummary' => 'Attending a medical conference in Sydney',
+            'journeys' => [
+                [
+                    'origin' => 'Perth',
+                    'destination' => 'Sydney',
+                    'date' => '2026-04-01',
+                    'time' => '09:00',
+                    'method' => JourneyMethod::Air->value,
+                ],
+            ],
+            'costCodes' => [],
+        ];
+    }
+
+    private function makeWorkflow(): ApprovalWorkflow
+    {
+        $workflow = ApprovalWorkflow::factory()->create(['is_active' => true]);
+
+        ApprovalStep::factory()->create([
+            'workflow_id' => $workflow->id,
+            'order' => 1,
+            'name' => 'Travel Approver Review',
+            'role' => 'travel_approver',
+        ]);
+
+        return $workflow;
+    }
+
+    public function test_submitting_form_with_active_workflow_sets_status_to_pending(): void
+    {
+        $this->makeWorkflow();
+
+        Livewire::actingAs($this->staff)
+            ->test('travel-request.create')
+            ->set($this->validFormData)
+            ->call('submit');
+
+        $request = TravelRequest::first();
+        $this->assertNotNull($request);
+        $this->assertSame(TravelStatus::Pending, $request->status);
+        $this->assertNotNull($request->submitted_at);
+    }
+
+    public function test_submitting_form_with_active_workflow_creates_pending_approval(): void
+    {
+        $this->makeWorkflow();
+
+        Livewire::actingAs($this->staff)
+            ->test('travel-request.create')
+            ->set($this->validFormData)
+            ->call('submit');
+
+        $request = TravelRequest::first();
+        $this->assertCount(1, $request->approvals);
+        $this->assertSame(ApprovalStatus::Pending->value, $request->approvals->first()->status->value);
+    }
+
+    public function test_submitting_form_with_no_active_workflow_shows_error(): void
+    {
+        Livewire::actingAs($this->staff)
+            ->test('travel-request.create')
+            ->set($this->validFormData)
+            ->call('submit')
+            ->assertHasErrors(['workflow']);
+
+        $this->assertDatabaseCount('travel_requests', 0);
+    }
+
+    public function test_saving_draft_does_not_submit_for_approval(): void
+    {
+        $this->makeWorkflow();
+
+        Livewire::actingAs($this->staff)
+            ->test('travel-request.create')
+            ->set($this->validFormData)
+            ->call('saveDraft');
+
+        $request = TravelRequest::first();
+        $this->assertNotNull($request);
+        $this->assertSame(TravelStatus::Draft, $request->status);
+        $this->assertNull($request->submitted_at);
+        $this->assertCount(0, $request->approvals);
+    }
+}