timmybee/travel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix LDAP authentication failures #7

Merged
timmybee merged 1 commits from worktree-ldap-issues into master 2026-03-06 10:35:45 +08:00
Conversation 0 Commits 1 Files Changed 3 +18 -1
timmybee commented 2026-03-06 10:34:56 +08:00
Owner
Copy Link

Summary

  • Add missing LDAP environment variables to .env.example (host, base DN, bind credentials)
  • Fix login to use uid attribute for LDAP user lookup instead of username
  • Override getLdapGuidColumn()/getLdapDomainColumn() in User model to match migration column names (ldap_guid/ldap_domain)

Test plan

  • Verified LDAP user lookup via LdapRecord finds user by uid
  • Verified Auth::attempt() successfully authenticates against OpenLDAP
  • All 5 existing login tests pass
## Summary - Add missing LDAP environment variables to `.env.example` (host, base DN, bind credentials) - Fix login to use `uid` attribute for LDAP user lookup instead of `username` - Override `getLdapGuidColumn()`/`getLdapDomainColumn()` in User model to match migration column names (`ldap_guid`/`ldap_domain`) ## Test plan - [x] Verified LDAP user lookup via LdapRecord finds user by `uid` - [x] Verified `Auth::attempt()` successfully authenticates against OpenLDAP - [x] All 5 existing login tests pass
timmybee added 1 commit 2026-03-06 10:34:56 +08:00
Fix LDAP authentication failures
All checks were successful
linter / quality (pull_request) Successful in 1m35s
Details
security / Dependency Audit (pull_request) Successful in 1m19s
Details
security / Static Analysis (pull_request) Successful in 1m32s
Details
tests / ci (8.4) (pull_request) Successful in 2m36s
Details
tests / ci (8.5) (pull_request) Successful in 1m37s
Details
bbcffe64b7 
- Add missing LDAP env vars to .env.example (host, base DN, bind credentials)
- Use 'uid' instead of 'username' as the LDAP lookup attribute in Auth::attempt
- Override getLdapGuidColumn/getLdapDomainColumn in User model to match
  migration column names (ldap_guid/ldap_domain vs default guid/domain)
timmybee merged commit fd53a28f03 into master 2026-03-06 10:35:45 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
timmybee
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: timmybee/travel#7
Delete Branch "worktree-ldap-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?